Re: [PATCH v3 5/9] KVM: MMU: introduce SPTE_WRITE_PROTECT bit

From: Xiao Guangrong
Date: Mon Apr 23 2012 - 23:34:43 EST


On 04/24/2012 08:45 AM, Marcelo Tosatti wrote:


>> I think it is not too hard to check. :)
>
> You are minimizing the possible impact these modifications have.
>
> Perhaps you should prepare code under mmu_lock to handle concurrent spte
> R->W updates first, and then later introduce the concurrent updates. In
> a way that its clear for somebody reading the code that parallel updates
> can happen (say read spte once, work on local copy, later re-read spte).
>


Good idea. I will refine it in the next version. Thank you, Marcelo! :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/