Re: [PATCH V2 4/9] ata/sata_mv: Remove conditional compilation ofclk code

[Sergei Shtylyov]

Hello.

On 24-04-2012 11:05, Viresh Kumar wrote:

> > I don't think this change is correct. With the old semantics, it was:

> Sorry. :(

> > If we have CLK support, we expect there to be a clock for sata_mv, and
> > if there is no such clock, output a notice message, something is
> > probably wrong, i expected there to be a clock.

> > The new semantics are:

> > We expect there to be a clock for sata_mv, and if there is no such
> > clock, output a notice message, something is probably wrong, i
> > expected there to be a clock.

> > We are going to see this notice message much more, when it is not
> > expected.

> So, the only problem is this message?
> How do you suggest to tackle this now. Have #ifdef,#endif around this print?

   When there's no CONFIG_HAVE_CLK, if clk_get() returns NULL, not error, 
there'll be no message.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/