Re: [PATCH V3 07/12] ata/sata_mv: Remove conditional compilation ofclk code

From: viresh kumar
Date: Tue Apr 24 2012 - 13:05:25 EST


On 4/24/12, Andrew Lunn <andrew@xxxxxxx> wrote:
> static int __clk_enable(struct clk *clk)
> {
> int ret = 0;
>
> if (!clk)
> return 0;
>
> if (WARN_ON(clk->prepare_count == 0))
> return -ESHUTDOWN;
>
> this should actually be clk_prepare_enable(). Did you see my
> patches adding generic clk framework support for Orion. I fixed
> this as part of that patch set.

Sorry for missing it earlier. Ya i know it must be clk_prepare_enable(),
but it wasn't motive of my patchset.

Sorry, i haven't gone through your patches for Orion.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/