Re: Breaking userspace? Re: 3.0.24 broke aufofs on mixed 32/64bit environment

[Linus Torvalds]

On Tue, Apr 24, 2012 at 9:12 AM, Michael Tokarev <mjt@xxxxxxxxxx> wrote:
>
> The userspace is running debian stable (squeeze).  Debian has autofs
> package based on upstream 5.0.4 version.  That (upstream) version has
> the "bug-compat" code in it, in daemon/automount.c:
>
> static size_t get_kpkt_len(void)
> {
>        size_t pkt_len = sizeof(struct autofs_v5_packet);
>        struct utsname un;
>
>        uname(&un);
>
>        if (pkt_len % 8) {
>                if (strcmp(un.machine, "alpha") == 0 ||
>                    strcmp(un.machine, "ia64") == 0 ||
>                    strcmp(un.machine, "x86_64") == 0 ||
>                    strcmp(un.machine, "ppc64") == 0)
>                        pkt_len += 4;

Ugh.

So how did this break for Thomas Mayer (there was another person
involved too, I forget the details)? Is this code somehow
config-dependent so that it doesn't even get compiled for some cases?

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/