Re: [PATCH] twl-regulator: Allow CONFIG_TWL4030_ALLOW_UNSUPPORTEDto be requested.

From: NeilBrown
Date: Wed Apr 25 2012 - 06:00:06 EST


On Wed, 25 Apr 2012 09:24:18 +0100 Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, Apr 25, 2012 at 12:29:24PM +1000, NeilBrown wrote:
> >
> > twl-regulator.c changes behaviour slightly depending on
> > CONFIG_TWL4030_ALLOW_UNSUPPORTED
> > However that config option is not currently listed in any Kconfig
> > file.
> > So add the option to allow it to be chosen.
>
> Shouldn't this be hidden behind _EXPERIMENTAL and/or enabled by the
> board in platform data/device tree? Kconfig feels like the wrong place
> to do this sort of configuration.

That make sense - but I cannot find a good place to put the flag.
TWL doesn't have any twl-specific platform data, it just uses
struct regulator_init_data. I don't suppose it would be acceptable
to tuck an 'allow_unsupported' flag inside 'struct regulation_constraints'?

I'm not sure how else to do it without fairly major surgery.

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature