Re: [PATCH v2 1/2] pinctrl: add pinctrl_provide_dummies interfacefor platforms to use

[Dong Aisheng]

On Wed, Apr 25, 2012 at 07:19:43PM +0800, Linus Walleij wrote:
> On Wed, Apr 25, 2012 at 11:49 AM, Dong Aisheng
> <aisheng.dong@xxxxxxxxxxxxx> wrote:
> > On Wed, Apr 25, 2012 at 03:00:23AM +0800, Stephen Warren wrote:
> 
> >> The only thing that should be calling pinctrl_request_gpio() is a GPIO
> >> driver. It should only be calling it for the GPIOs it manages. I'd
> >> expect that if a platform's pinctrl driver was not yet written to
> >> support the GPIO functionality, then the GPIO driver would not be
> >> calling this function.
> >>
> > Hmm, pinctrl gpio is in the same situation as pinctrl state that gpio
> > driver may be shared between several platforms, with pinctrl support
> > or not.
> 
> I think it's mostly safe to assume that either:
> 
I just saw your reply after i sent out the revised patch...

> - pinctrl calls from GPIO drivers gets stubbed out totally due to
>   CONFIG_PINCTRL not being selected
> 
Yes, we already have that in include/linux/pinctrl/consumer.h

> or:
> 
> - You need to pass a token through platform data to the
>   GPIO driver telling it whether it needs to request pins for
>   it's GPIOs or not. Just a bool should work fine?
> 
Yes, this is an alternative way.
I'm using a similar way, but pass the data to pinctrl core
rather than gpio driver. Then it is be handled together with
dummy state in platform code.

Do you think if the current way i used is ok?
Or i need to change to your proposed way?

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/