Re: [PATCH] kgdb: Do not allow function tracing of kgdb code

From: Jason Wessel
Date: Wed Apr 25 2012 - 11:24:03 EST


On 04/25/2012 10:18 AM, Steven Rostedt wrote:
> As function tracing the kgdb code can cause issues, as kgdb is a
> debugger itself, do not trace the kgdb functions.
>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> index 532d2e0..b7828ce 100644
> --- a/arch/x86/kernel/Makefile
> +++ b/arch/x86/kernel/Makefile
> @@ -15,6 +15,7 @@ CFLAGS_REMOVE_pvclock.o = -pg
> CFLAGS_REMOVE_kvmclock.o = -pg
> CFLAGS_REMOVE_ftrace.o = -pg
> CFLAGS_REMOVE_early_printk.o = -pg
> +CFLAGS_REMOVE_kgdb.o = -pg
> endif
>
> obj-y := process_$(BITS).o signal.o entry_$(BITS).o
>
>

Per our off mailing list discussion, I absolutely agree.

This came up in the course of looking through the new code proposed
around removing the stop machine for ftrace.

Acked-by: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>

Cheers,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/