Re: [PATCH] mISDN: Ignore return value of driver_for_each_devicein function hfcpci_softirq.

From: David Miller
Date: Wed Apr 25 2012 - 20:42:41 EST


From: Krzysztof Wilczynski <krzysztof.wilczynski@xxxxxxxxx>
Date: Wed, 25 Apr 2012 00:13:50 +0100

> Function hfcpci_softirq uses driver_for_each_device to call _hfcpci_softirq for
> each device. Given that _hfcpci_softirq always returns 0, we collect this return
> value and simply do nothing with it. This is purely to address the following
> warning during compilation time:
>
> drivers/isdn/hardware/mISDN/hfcpci.c: In function ʽhfcpci_softirqʼ:
> drivers/isdn/hardware/mISDN/hfcpci.c:2319: warning: ignoring return value of
> ʽdriver_for_each_deviceʼ, declared with attribute warn_unused_result
>
> Similar approach was used in function cx18_alsa_exit from "cx18-alsa-main.c".
>
> Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@xxxxxxxxx>

There is no value in the warning if we simply convert each such case
to ignore the return value.

I'm not applying this, at least not with a more intelligent analysis
of why any error or other non-zero value signalled by
driver_for_each_device should be completely ignored, and no error
handling should be performed.
θΊ{.nΗ+?·???­?+%?Λlzwm?ιb?맲ζμrΈ?zX§»?w??{ayΊΚ?Ϊ?λ,j­ʼf£ʼ·h??ΰzΉ?w?ʼΈ ʼ·¦j:+v?¨?wθjΨmΆ??Ύ«?κηzZ+?ω???έʼj"?ϊ!ΆiO?ζ¬z·?vΨ^Άm§?πΓ nΖ?ΰώY&?