Re: [tip:core/locking] watchdog, hpwdt: Remove priority option for NMI callback

[Wim Van Sebroeck]

Hi All,

> Commit-ID:  09ee10143658cd021d879ead61ead72a196302b6
> Gitweb:     http://git.kernel.org/tip/09ee10143658cd021d879ead61ead72a196302b6
> Author:     Don Zickus <dzickus@xxxxxxxxxx>
> AuthorDate: Thu, 29 Mar 2012 16:11:15 -0400
> Committer:  Ingo Molnar <mingo@xxxxxxxxxx>
> CommitDate: Wed, 25 Apr 2012 12:43:33 +0200
> 
> watchdog, hpwdt: Remove priority option for NMI callback
> 
> The NMI_UNKNOWN bucket only allows for one function to register
> to it. The reason for that is because only functions which can
> not determine if the NMI belongs to them or not should register
> and would like to assume/swallow any NMI they see.
> 
> As a result it doesn't make sense to let more than one function
> like this register.  In fact, letting a second function fail
> allows us to know that more than one function is going to
> swallow NMIs on the current system. This is better than silently
> being ignored.
> 
> Therefore hpwdt's priority mechanism doesn't make sense any
> more.  They will be always first on the NMI_UNKNOWN queue, if
> they register.
> 
> Removing this parameter cleans up the code and simplifies things
> for the next patch which changes how nmis are registered.
> 
> Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx>
> Cc: Thomas Mingarelli <thomas.mingarelli@xxxxxx>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Link: http://lkml.kernel.org/r/1333051877-15755-2-git-send-email-dzickus@xxxxxxxxxx
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>

This is the feedback I have from Tom which he discussed with Don:
> I don't like this patch because the Virtual NMI button doesn't come through the pretimeout routine. It is taken by the
system as an IOCK NMI error and no log messages in our IML.
> Our BIOS is not able to source the NMI.

And since then it became quiet. Imho: this needs more discussion...

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/