[PATCH RESEND 3/7] staging: sm7xx: use dynamic debug support

From: Javier M. Mellid
Date: Thu Apr 26 2012 - 14:46:21 EST


This patch uses dynamic debug support.

Tested with SM712

Signed-off-by: Javier M. Mellid <jmunhoz@xxxxxxxxxx>
---
drivers/staging/sm7xx/smtcfb.c | 30 ++++++++++++------------------
1 files changed, 12 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/sm7xx/smtcfb.c b/drivers/staging/sm7xx/smtcfb.c
index abed491..69721c2 100644
--- a/drivers/staging/sm7xx/smtcfb.c
+++ b/drivers/staging/sm7xx/smtcfb.c
@@ -33,12 +33,6 @@

#include "smtcfb.h"

-#ifdef DEBUG
-#define smdbg(format, arg...) printk(KERN_DEBUG format , ## arg)
-#else
-#define smdbg(format, arg...)
-#endif
-
struct screen_info smtc_screen_info;

/*
@@ -134,8 +128,9 @@ static void sm712_set_timing(struct smtcfb_info *sfb,
int i = 0, j = 0;
u32 m_nScreenStride;

- smdbg("\nppar_info->width = %d ppar_info->height = %d"
- "sfb->fb.var.bits_per_pixel = %d ppar_info->hz = %d\n",
+ dev_dbg(&sfb->dev->dev,
+ "ppar_info->width=%d ppar_info->height=%d"
+ "sfb->fb.var.bits_per_pixel=%d ppar_info->hz=%d\n",
ppar_info->width, ppar_info->height,
sfb->fb.var.bits_per_pixel, ppar_info->hz);

@@ -145,13 +140,14 @@ static void sm712_set_timing(struct smtcfb_info *sfb,
VGAMode[j].bpp == sfb->fb.var.bits_per_pixel &&
VGAMode[j].hz == ppar_info->hz) {

- smdbg("\nVGAMode[j].mmSizeX = %d VGAMode[j].mmSizeY ="
- "%d VGAMode[j].bpp = %d"
- "VGAMode[j].hz=%d\n",
- VGAMode[j].mmSizeX, VGAMode[j].mmSizeY,
- VGAMode[j].bpp, VGAMode[j].hz);
+ dev_dbg(&sfb->dev->dev,
+ "VGAMode[j].mmSizeX=%d VGAMode[j].mmSizeY=%d"
+ "VGAMode[j].bpp=%d VGAMode[j].hz=%d\n",
+ VGAMode[j].mmSizeX, VGAMode[j].mmSizeY,
+ VGAMode[j].bpp, VGAMode[j].hz);

- smdbg("VGAMode index=%d\n", j);
+ dev_dbg(&sfb->dev->dev,
+ "VGAMode index=%d\n", j);

smtc_mmiowb(0x0, 0x3c6);

@@ -805,16 +801,14 @@ static int __init sm712vga_setup(char *options)
{
int index;

- if (!options || !*options) {
- smdbg("\n No vga parameter\n");
+ if (!options || !*options)
return -EINVAL;
- }

smtc_screen_info.lfb_width = 0;
smtc_screen_info.lfb_height = 0;
smtc_screen_info.lfb_depth = 0;

- smdbg("\nsm712vga_setup = %s\n", options);
+ pr_debug("sm712vga_setup = %s\n", options);

for (index = 0;
index < ARRAY_SIZE(vesa_mode);
--
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/