Re: [RFC] propagate gfp_t to page table alloc functions

From: Andrew Morton
Date: Thu Apr 26 2012 - 23:06:57 EST


On Fri, 27 Apr 2012 11:24:32 +0900 Minchan Kim <minchan@xxxxxxxxxx> wrote:

> I was about to add warning in __vmalloc internal if caller uses GFP_NOIO, GFP_NOFS, GFP_ATOMIC
> with Nick's comment and let them make to fix it. But it seems Andrew doesn't agree.

I do, actually.

> Andrew, please tell me your opinion for fixing this problem.

Only call vmalloc() from GFP_KERNEL contexts. Go ahead, add the
WARN_ONCE() and let's see what happens.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/