Re: [PATCH 06/12] perf/x86-ibs: Precise event sampling with IBS forAMD CPUs

From: Stephane Eranian
Date: Fri Apr 27 2012 - 11:57:12 EST


On Fri, Apr 27, 2012 at 5:30 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Fri, 2012-04-27 at 17:18 +0200, Robert Richter wrote:
>> There is nothing wrong with it. I already implemented that the
>> MISC_EXACT flag is supported. But, the flag is basically not used in
>> the perf tool and there is no modifier or so to only get a precise
>> rip.
>
> Just because userspace doesn't dtrt doesnt mean its a good idea to wreck
> the kernel side of things.
>
> Instead fix the userspace.
>
I was going to suggest you add an option to perf annotate/report to filter out
non exact_ip samples. That can't be that hard to do.


> I'll simply not take patches that silently drops samples.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/