Re: [PATCH] watchdog: fix for lockup detector breakage on resume

From: Sameer Nanda
Date: Fri Apr 27 2012 - 18:20:21 EST


On Fri, Apr 27, 2012 at 3:03 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 27 Apr 2012 14:40:01 -0700
> Sameer Nanda <snanda@xxxxxxxxxxxx> wrote:
>
>> On Fri, Apr 27, 2012 at 2:12 PM, Andrew Morton
>> <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> This call actually happens on "exit from suspend" or "entry into
>> resume" processing so
>> how about something like:
>>
>> On exit from suspend we force an offline->online transition on the boot CPU so
>> that the PMU state that was lost while in suspended state gets set up properly
>> for the boot CPU. ÂThis information is required for restarting the NMI watchdog.
>
> OK, let's use that.
>
>> > Also, this is all dead code if CONFIG_SUSPEND=n, so how about
>> >
>
> You had no comments about this?
Looks good to me.

Thanks for including this in the mm tree!

--
Sameer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/