Re: [RFC PATCH] namespaces: fix leak on fork() failure

From: Mike Galbraith
Date: Sun Apr 29 2012 - 23:25:39 EST


On Sun, 2012-04-29 at 19:59 -0700, Eric W. Biederman wrote:
> Oleg Nesterov <oleg@xxxxxxxxxx> writes:

> > Yes, but please note that this change also checks "new == NULL", so I
> > still think the patch is correct.
>
> Sort of. It is correct in the sense that it performs magic checks on
> it's arguments to see that it's caller is exit_task_namespaces called
> from the fork failure path.

Yeah, did that to keep namespace fix in namespace source. Bad idea even
with circles and arrows "hey, I'm an unborn red-headed stepchild".

-Mike



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/