Re: [PATCH 0/3] hid: Enable report fixup on rebind

From: Jiri Kosina
Date: Mon Apr 30 2012 - 08:06:59 EST


On Mon, 30 Apr 2012, Henrik Rydberg wrote:

> > Regarding the code, could it be the time to fix naming of report
> > descriptor-handling functions to improve distinction from report-handling
> > ones? I'm attaching a patch applying on top of Henrik's changes which should
> > illustrate the proposal.
>
> The changes you propose force changes to out-of-tree-drivers, without
> any obvious benefit.

I agree that *_parse_rdesc() would be much better than *_parse_report()
(we have been having this slight misnomer in the HID code since ever).

I wouldn't care too much about out-of-tree drivers, they have to adapt
gradually to our random HID API changes anyway.

Thanks to both of you,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/