[PATCH 4/5] perf annotate browser: Remove the vertical line after the percentages

From: Arnaldo Carvalho de Melo
Date: Wed May 02 2012 - 15:42:51 EST


From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

It is confusing when used with jump -> target lines.

Requested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Mike Galbraith <efault@xxxxxx>
Cc: Namhyung Kim <namhyung@xxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Stephane Eranian <eranian@xxxxxxxxxx>
Link: http://lkml.kernel.org/n/tip-xeiyfsxptwtmlvowledg6wpy@xxxxxxxxxxxxxx
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
---
tools/perf/ui/browsers/annotate.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index d203daf..a90680b 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -72,7 +72,6 @@ static void annotate_browser__write(struct ui_browser *self, void *entry, int ro
slsmg_write_nstring(" ", 9);
}

- ui_browser__write_graph(self, SLSMG_VLINE_CHAR);
SLsmg_write_char(' ');

/* The scroll bar isn't being used */
@@ -83,9 +82,9 @@ static void annotate_browser__write(struct ui_browser *self, void *entry, int ro
ui_browser__set_color(self, HE_COLORSET_CODE);

if (!*dl->line)
- slsmg_write_nstring(" ", width - 10);
+ slsmg_write_nstring(" ", width - 9);
else if (dl->offset == -1)
- slsmg_write_nstring(dl->line, width - 10);
+ slsmg_write_nstring(dl->line, width - 9);
else {
char bf[256];
u64 addr = dl->offset;
@@ -138,7 +137,7 @@ static void annotate_browser__write(struct ui_browser *self, void *entry, int ro
scnprintf(bf, sizeof(bf), "%-6.6s %s", dl->name, dl->ops.raw);
}

- slsmg_write_nstring(bf, width - 12 - printed);
+ slsmg_write_nstring(bf, width - 11 - printed);
}

if (current_entry)
@@ -176,7 +175,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser)
if (!bcursor->jump_target)
start_width += ab->offset_width + 1;

- __ui_browser__line_arrow(browser, 10, from, to, start_width);
+ __ui_browser__line_arrow(browser, 9, from, to, start_width);
}

static unsigned int annotate_browser__refresh(struct ui_browser *browser)
--
1.7.9.2.358.g22243

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/