Re: [PATCH] CHROMIUM: tpm: tpm_tis_i2c: Lock the I2C adapter for a sequence of requests.

From: Peter Hüwe
Date: Wed May 02 2012 - 16:54:35 EST


Am Mittwoch 02 Mai 2012, 21:06:14 schrieb Bryan Freed:
> We could (in the unmodified version of this driver) replace all the
> iic_tpm_read() calls of one byte (which sends an address byte before
> reading a data byte) with an i2c_smbus_read_byte_command() call which
> does the same thing.

Unfortunately we have to use two seperate transfers (write/read) for a single
byte read as the device does not support "repeated start" conditions and will
simply fail to respond.

The device has some quirks that the driver has to workaround,
one is the repeated start problem, the other is the locking of the device.
If you can come up with a better solution I'd like to try it out if it's
compatible with the device.

Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/