[PATCH V1] gpio: fix bits conflict for gpio flags

From: Laxman Dewangan
Date: Mon May 07 2012 - 06:29:05 EST


The bit 2 and 3 in GPIO flag are allocated for the
flag OPEN_DRAIN/OPEN_SOURCE. These bits are reused
for the flag EXPORT/EXPORT_CHANGEABLE and so creating
conflict.
Fix this conflict by allocating bit 4 and 5 for the
flag EXPORT/EXPORT_CHANGEABLE.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
---
This is broken by commit
commit fc3a1f04f5040255cbc086c419e4237f29f89f88
Author: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

gpio: add flags to export GPIOs when requesting


include/linux/gpio.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/gpio.h b/include/linux/gpio.h
index d1890d4..0118141 100644
--- a/include/linux/gpio.h
+++ b/include/linux/gpio.h
@@ -20,8 +20,8 @@
/* Gpio pin is open source */
#define GPIOF_OPEN_SOURCE (1 << 3)

-#define GPIOF_EXPORT (1 << 2)
-#define GPIOF_EXPORT_CHANGEABLE (1 << 3)
+#define GPIOF_EXPORT (1 << 4)
+#define GPIOF_EXPORT_CHANGEABLE (1 << 5)
#define GPIOF_EXPORT_DIR_FIXED (GPIOF_EXPORT)
#define GPIOF_EXPORT_DIR_CHANGEABLE (GPIOF_EXPORT | GPIOF_EXPORT_CHANGEABLE)

--
1.7.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/