Re: [PATCH 3/7] perf tools: Add parser for dynamic PMU events

From: Peter Zijlstra
Date: Mon May 07 2012 - 07:01:44 EST


On Wed, 2012-05-02 at 20:26 +0200, Robert Richter wrote:
> This patch adds support for pmu specific event parsers by extending
> the pmu handler. The event syntax is the same as for tracepoints:
>
> <subsys>:<name>:<modifier>

I really don't like this

> - event_legacy_tracepoint sep_dc |
> + event_legacy_generic sep_dc |

That 'legacy' in there is a good hint you shouldn't be using this.

Ideally I'd get rid of all legacy formats eventually, we really
shouldn't be adding new ones.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/