Re: [patch 02/10] mm: bootmem: remove redundant offset check whenfinally freeing bootmem

From: Tejun Heo
Date: Mon May 07 2012 - 14:08:28 EST


On Mon, May 07, 2012 at 01:37:44PM +0200, Johannes Weiner wrote:
> When bootmem releases an unaligned BITS_PER_LONG pages chunk of memory
> to the page allocator, it checks the bitmap if there are still
> unreserved pages in the chunk (set bits), but also if the offset in
> the chunk indicates BITS_PER_LONG loop iterations already.
>
> But since the consulted bitmap is only a one-word-excerpt of the full
> per-node bitmap, there can not be more than BITS_PER_LONG bits set in
> it. The additional offset check is unnecessary.
>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/