Re: [PATCH 2/3] irq_remap: fix the UP build failure

From: Ingo Molnar
Date: Tue May 08 2012 - 05:10:07 EST

* Suresh Siddha <suresh.b.siddha@xxxxxxxxx> wrote:

> Fix the below UP build failure with CONFIG_IRQ_REMAP enabled.
> drivers/iommu/intel_irq_remapping.c:955:19: error: âstruct irq_dataâ has no member named âaffinityâ


> +++ b/drivers/iommu/intel_irq_remapping.c
> +#ifdef CONFIG_SMP
> +#endif
> +#ifdef CONFIG_SMP
> +#endif
> +#ifdef CONFIG_SMP
> +#endif
> +#ifdef CONFIG_SMP
> +#endif

Adding this many #ifdefs is a bit sad. Could we not make the UP
side have the (supposedly zero length!) affinity cpumask
instead, or so, and make sure that the SMP functions compile to
something sensible on UP?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at