Re: [PATCH 3/3] irq_remap: fix the 'sub_handle' uninitialized warning
From: Ingo Molnar
Date: Tue May 08 2012 - 05:15:34 EST
another problem is that drivers/iommu/intel_irq_remapping.c is
supplied with comments rather poorly - I have to page down
almost 300 lines to see the first substantial comment! Copyright
notices would be nice as well.
So lets do a better job and document this thing a bit better.
Please also align structure definitions vertically, like we
typically to do in new code.
The file names should probably also be standardized (but that
should come via a Git space pull request, using git mv and
such). What we have currently is pretty random: 'dmar.c' should
probably be dma_remap.c, and *irq_remapping.c should probably be
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/