[PATCH bugfix v3.4] ALSA: hda - fix "silence after S3" regression

From: Konstantin Khlebnikov
Date: Tue May 08 2012 - 09:08:16 EST

This fixes regression in shd-hda-codec after 785f857d1cb0856b612b46a0545b74aa2
("ALSA: hda - Set codec to D3 forcibly even if not used")

hda_set_power_state() call must be explicitly protected against recursive
snd_hda_power_up/down() calls, otherwise it accidentally switches device into
D0 right before suspend. As result after resume sound device stays in D3 state
and does not works because driver believes that the device is on already.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
sound/pci/hda/hda_codec.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 7a8fcc4..a0ea9d6 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -5444,10 +5444,14 @@ int snd_hda_suspend(struct hda_bus *bus)
list_for_each_entry(codec, &bus->codec_list, list) {
if (hda_codec_is_power_on(codec))
- else /* forcibly change the power to D3 even if not used */
+ else {
+ /* forcibly change the power to D3 even if not used */
+ codec->power_transition = 1;
codec->afg ? codec->afg : codec->mfg,
+ codec->power_transition = 0;
+ }
if (codec->patch_ops.post_suspend)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/