Re: [PATCH 5/6 v3] mfd: tps65910-irq: Add devicetree init support

[Mark Brown]

On Tue, May 08, 2012 at 12:11:31PM -0700, Rhyland Klein wrote:

> Is this more what you would expect? If the dt code initialized the
> irq_base to 0 instead of -1 then this should also work.

> pdata->irq_base = irq_alloc_descs(-1, pdata->irq_base,
> 			tps65910->irq_num, -1);
> if (pdata->irq_base <= 0) {
> 	dev_err(tps65910->dev, "Failed to allocate irq descs: %d\n",
> 		pdata->irq_base);
> 	return pdata->irq_base;
> }

More like:

	if (pdata->irq_base)
		base = pdata->irq_base;
	else
		base = 0;
	pdata->irq_base = irq_alloc_descs(base, 0,

Attachment: signature.asc
Description: Digital signature