Re: [PATCH] ipv4: Fixed checkpatch warnings and errors
From: David Miller
Date: Tue May 08 2012 - 13:04:16 EST
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Tue, 08 May 2012 08:13:46 -0700
> On 05/08/2012 03:58 AM, Cristian Chilipirea wrote:
>> Fixed warnings and errors in af_inet.c.
>> #ifdef CONFIG_COMPAT
>> -static int inet_compat_ioctl(struct socket *sock, unsigned int cmd,
>> -unsigned long arg)
>> +static int inet_compat_ioctl(struct socket *sock, unsigned int cmd,
>> + unsigned long arg)
> That is so much worse than what was there before.
> Lets stop useless checkpatch crap on existing code
> unless it's really ugly.
Agreed, this patch is terrible.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/