Re: [PATCH 04/23] x86, realmode: Move reboot_32.S to unified realmodecode

[Paolo Bonzini]

Il 08/05/2012 20:22, Jarkko Sakkinen ha scritto:
> +	xorl	%ecx, %ecx
> +	movl	%cr0, %edx
> +	andl	$0x00000011, %edx
> +	orl	$0x60000000, %edx
> +	movl	%edx, %cr0
> +	movl	%ecx, %cr3
> +	movl	%cr0, %edx
> +	andl	$0x60000000, %edx	/* If no cache bits -> no wbinvd */

Shouldn't this be a testl?

> +	jz	2f
> +	wbinvd
> +2:
> +	andb	$0x10, %dl

... because otherwise this is really a mov $0, %edx and it sounds wrong.
 It doesn't really matter, nobody really uses bit 4 of CR0 anymore,
still would be nice to fix it.

> +	movl	%edx, %cr0

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/