Re: [PATCH] slab/mempolicy: always use local policy from interruptcontext v3

From: KOSAKI Motohiro
Date: Wed May 09 2012 - 04:04:12 EST


>> > +       if (!in_interrupt() || !policy || policy->flags & MPOL_F_LOCAL)
>> >                return numa_node_id();
>>
>> I think your patch is correct. but I don't like interrupt context
>> dereference current task.
>> It would be nice if we only see current->mempolicy when !in_interrupt.
>>
>> But this doesn't mean NAK anyway.
>>
>>  Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
>
> Sigh, this was acked by Christoph and KOSAKI when the logic is reversed
> and does the exact opposite of what's intended?

Ahhh, Good catch!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/