[PATCH 2/5, resend] x86: adjust quirk handler sectionannotations

From: Jan Beulich
Date: Wed May 09 2012 - 05:01:37 EST


This is in preparation to adjust modpost to check section mismatches
on most of the .pci_fixup* sections:

.pci_fixup_final is only used from .init.text, and hence can (along
with the respective handler functions) reside in .init.*.

Several other .pci_fixup_* sections are needed only during boot and
suspend/resume, and can therefore be moved into .init.* if
!CONFIG_PM.

Handler (and eventual static data) section annotations need to/can be
changed accordingly.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

---
arch/x86/kernel/pci-dma.c | 2 +-
arch/x86/kernel/quirks.c | 2 +-
arch/x86/pci/fixup.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)

--- 3.4-rc6/arch/x86/kernel/pci-dma.c
+++ 3.4-rc6-pci-fixup-sections/arch/x86/kernel/pci-dma.c
@@ -261,7 +261,7 @@ rootfs_initcall(pci_iommu_init);
#ifdef CONFIG_PCI
/* Many VIA bridges seem to corrupt data for DAC. Disable it here */

-static __devinit void via_no_dac(struct pci_dev *dev)
+static __init void via_no_dac(struct pci_dev *dev)
{
if (forbid_dac == 0) {
dev_info(&dev->dev, "disabling DAC on VIA PCI bridge\n");
--- 3.4-rc6/arch/x86/kernel/quirks.c
+++ 3.4-rc6-pci-fixup-sections/arch/x86/kernel/quirks.c
@@ -8,7 +8,7 @@

#if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_SMP) && defined(CONFIG_PCI)

-static void __devinit quirk_intel_irqbalance(struct pci_dev *dev)
+static void __init quirk_intel_irqbalance(struct pci_dev *dev)
{
u8 config;
u16 word;
--- 3.4-rc6/arch/x86/pci/fixup.c
+++ 3.4-rc6-pci-fixup-sections/arch/x86/pci/fixup.c
@@ -249,7 +249,7 @@ static struct pci_ops quirk_pcie_aspm_op
* the root port in an array for fast indexing. Replace the bus ops
* with the modified one.
*/
-static void pcie_rootport_aspm_quirk(struct pci_dev *pdev)
+static void __init pcie_rootport_aspm_quirk(struct pci_dev *pdev)
{
int cap_base, i;
struct pci_bus *pbus;
@@ -411,7 +411,7 @@ DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_V
*/
static u16 toshiba_line_size;

-static const struct dmi_system_id __devinitconst toshiba_ohci1394_dmi_table[] = {
+static const struct dmi_system_id toshiba_ohci1394_dmi_table[] = {
{
.ident = "Toshiba PS5 based laptop",
.matches = {
@@ -447,7 +447,7 @@ static void __devinit pci_pre_fixup_tosh
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TI, 0x8032,
pci_pre_fixup_toshiba_ohci1394);

-static void __devinit pci_post_fixup_toshiba_ohci1394(struct pci_dev *dev)
+static void pci_post_fixup_toshiba_ohci1394(struct pci_dev *dev)
{
if (!dmi_check_system(toshiba_ohci1394_dmi_table))
return; /* only applies to certain Toshibas (so far) */



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/