Re: [PATCH] trace: power: add trace_clock_set_parent

[Colin Cross]

On Wed, May 9, 2012 at 4:50 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Wed, 2012-05-09 at 16:21 -0700, Colin Cross wrote:
>> Adds a new trace event to be called from clk_set_parent.  Some
>> cpufreq drivers, including Tegra, reparent the cpu clock to a
>> slower clock while the main pll is relocking, tracing
>> clk_set_parent allows traces to show how for long the cpu is
>> running slower.
>>
>> Uses a separate TRACE_EVENT instead of the clock event class to
>> allow the event to contain string names for the child and the
>> parent.
>>
>> Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx>
>> ---
>>  include/trace/events/power.h |   19 +++++++++++++++++++
>>  1 files changed, 19 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/trace/events/power.h b/include/trace/events/power.h
>> index cae9a94..2b81df6 100644
>> --- a/include/trace/events/power.h
>> +++ b/include/trace/events/power.h
>> @@ -204,6 +204,25 @@ enum {
>>       TP_ARGS(name, state, cpu_id)
>>  );
>>
>> +TRACE_EVENT(clock_set_parent,
>> +
>> +     TP_PROTO(const char *name, const char *parent_name),
>> +
>> +     TP_ARGS(name, parent_name),
>> +
>> +     TP_STRUCT__entry(
>> +             __string(       name,           name            )
>> +             __string(       parent_name,    parent_name     )
>> +     ),
>> +
>> +     TP_fast_assign(
>> +             __assign_str(name, name);
>> +             __assign_str(name, parent_name);
>
> Don't you mean: __assign_str(parent_name, parent_name); ?

Yep, just noticed that in my traces, I'll send an updated patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/