Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-lengthrecord buffer
From: Linus Torvalds
Date: Wed May 09 2012 - 21:18:30 EST
On Wed, May 9, 2012 at 5:54 PM, Kay Sievers <kay@xxxxxxxx> wrote:
> How about this? It relaxes the need for KERN_CONT, but it limits
> continuation lines to repeated calls of the same thread.
Fair enough, looks reasonable.
Except your case-statement sucks. Having a "case 'c':" that basically
then immediately has an "if (it was not 'c')" is just disturbing. Just
move the code that is common to all the cases outside the case
statement entirely, and make the 'c' case not do anything at all, and
remove that crazy extraneous if-statement.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/