Re: [PATCH v4 6/7] x86/tlb: optimizing flush_tlb_mm

From: Peter Zijlstra
Date: Thu May 10 2012 - 04:33:31 EST


On Thu, 2012-05-10 at 13:00 +0800, Alex Shi wrote:
> Not every flush_tlb_mm execution moment is really need to evacuate all
> TLB entries, like in munmap, just few 'invlpg' is better for whole
> process performance, since it leaves most of TLB entries for later
> accessing.
>
> This patch is changing flush_tlb_mm(mm) to flush_tlb_mm(mm, start, end)
> in cases.

No I thoroughly hate this patch. Please do something like:

http://marc.info/?l=linux-arch&m=129952026504268&w=2

Afaict it achieves the same, doesn't mangle the tlb flush interfaces and
allows more arch to use generic code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/