Re: [PATCH v4 3/7] x86/flush_tlb: try flush_tlb_single one by onein flush_tlb_range

[Alex Shi]

>> +
>> +#define FLUSHALL_BAR	16
>> +
> 
> Btw, you can save a bunch of indenting on this function, let me add
> the final version here from the whole patchset so I can comment on it
> easier:
> 
>> void __flush_tlb_range(struct mm_struct *mm, unsigned long start,
>>                                 unsigned long end, unsigned long vmflag)
>> {
>>         preempt_disable();
>>         if (current->active_mm == mm) {
> 
> 	if (current->active_mm != mm)
> 		goto flush_all;
> 
> Now this whole piece below can move one indentation level to the left.
> 
> Then you can do:
> 
> 	if (!current->mm)
> 		goto leave;
> 
> and add the "leave" label below.
> 
> Now you're saving yet another indentation level, bringing the meat of
> the function at 1st indentation level, which is cool and gives you much
> more room so that you don't have to linebreak longer statements.
> 


sure, thanks! :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/