[v2 1/2] ARM: tegra20: MC: Remove unnecessary BUG*()

From: Hiroshi DOYU
Date: Fri May 11 2012 - 06:05:33 EST


Accessing interleaved MC register offsets/ranges are verified. BUG*()s
in accessors can be removed.

Signed-off-by: Hiroshi DOYU <hdoyu@xxxxxxxxxx>
---
drivers/memory/tegra20-mc.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/memory/tegra20-mc.c b/drivers/memory/tegra20-mc.c
index c0bfffa..2a437e9 100644
--- a/drivers/memory/tegra20-mc.c
+++ b/drivers/memory/tegra20-mc.c
@@ -53,12 +53,14 @@ struct tegra20_mc {

static inline u32 mc_readl(struct tegra20_mc *mc, u32 offs)
{
+ u32 val = 0;
+
if (offs < 0x24)
- return readl(mc->regs[0] + offs);
- BUG_ON(offs < 0x3c);
+ val = readl(mc->regs[0] + offs);
if (offs < 0x400)
- return readl(mc->regs[1] + offs - 0x3c);
- BUG();
+ val = readl(mc->regs[1] + offs - 0x3c);
+
+ return val;
}

static inline void mc_writel(struct tegra20_mc *mc, u32 val, u32 offs)
@@ -67,12 +69,10 @@ static inline void mc_writel(struct tegra20_mc *mc, u32 val, u32 offs)
writel(val, mc->regs[0] + offs);
return;
}
- BUG_ON(offs < 0x3c);
if (offs < 0x400) {
writel(val, mc->regs[1] + offs - 0x3c);
return;
}
- BUG();
}

static const char * const tegra20_mc_client[] = {
--
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/