Re: [PATCH v4 5/7] x86/tlb: add tlb flush all factor for specificCPU

From: Alex Shi
Date: Fri May 11 2012 - 08:51:19 EST


On 05/11/2012 05:04 PM, Peter Zijlstra wrote:

> On Fri, 2012-05-11 at 11:04 +0200, Peter Zijlstra wrote:
>
>>> NO, the first judgement is from CPU. But second '-1' is may from user
>>> setting in sysfs.
>>
>> Then you're doing it wrong. Don't allow setting the sysfs variable if !
>> cpu_has_invlpg.
>
> Better yet, don't create the sysfs file at all in that case.


Yes, true.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/