Re: [dm-devel] [Bcache v13 01/16] Only clone bio vecs that are in use

[Jeff Moyer]

[top posting fixed]

Kent Overstreet <koverstreet@xxxxxxxxxx> writes:

> 2012/5/10 Vivek Goyal <vgoyal@xxxxxxxxxx>:
>> On Wed, May 09, 2012 at 11:08:13PM -0400, Kent Overstreet wrote:
>>
>> [..]
>>> -
>>> - Â Â if (bio_integrity(bio)) {
>>> - Â Â Â Â Â Â bio_integrity_clone(clone, bio, GFP_NOIO, bs);
>>> -
>>> +#if 0
>>> + Â Â if (bio_integrity(bio))
>>> Â Â Â Â Â Â Â if (idx != bio->bi_idx || clone->bi_size < bio->bi_size)
>>> Â Â Â Â Â Â Â Â Â Â Â bio_integrity_trim(clone,
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âbio_sector_offset(bio, idx, 0), len);
>>> - Â Â }
>>> -
>>> +#endif
>>
>> Dead/debug code under "#if 0" ?
>>
> Oh, I never got around to figuring out what needed to be done with the
> bio integrity - presumably it'll have to be handled differently
> somehow (I'm assuming an index in the integrity bvec is intended to
> match up with an index in the regular bvec), but I don't have any way
> to test the integrity stuff.

The scsi debug module supports dif/dix, so you can use that for testing.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/