RE: [PATCH] staging: comedi: Add helper macro for comedi pci driverboilerplate

[H Hartley Sweeten]

On Friday, May 11, 2012 10:32 AM, Ian Abbott wrote:
> On 2012-05-11 18:07, H Hartley Sweeten wrote:
>> +int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
>> +		struct pci_driver *pci_driver)
>> +{
>> +	int ret;
>> +
>> +	ret = comedi_driver_register(comedi_driver);
>> +	if (ret<  0)
>> +		return ret;
>> +
>> +	pci_driver->name = comedi_driver->driver_name;
>
> I think it would be better if the driver modules that call this function 
> already had pci_driver->name initialized statically.

I agree, but this is how all the pci drivers do it now.

To change this will require auditing all the comedi pci drivers and adding
the static name.

Regards,
Hartley

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—