Re: [PATCH] net: of/phy: fix build error when phylib is built asa module

From: David Daney
Date: Fri May 11 2012 - 13:58:13 EST

On 05/11/2012 08:47 AM, BjÃrn Mork wrote:
CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use
IS_ENABLED macro to prevent build error:

ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Reported-by: Randy Dunlap<rdunlap@xxxxxxxxxxxx>
Cc: David Daney<david.daney@xxxxxxxxxx>
Signed-off-by: BjÃrn Mork<bjorn@xxxxxxx>

I was able to reproduce the failure, and this patch both fixes it and seems correct, so...

Acked-by: David Daney<david.daney@xxxxxxxxxx>

Sorry about this failure.

I wonder if this could be as banal as this? Not even build tested...

Should be wrapped into commit 25106022 if it works, to ensure


drivers/net/phy/mdio_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 83d5c9f..683ef1c 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -88,7 +88,7 @@ static struct class mdio_bus_class = {
.dev_release = mdiobus_release,

/* Helper function for of_mdio_find_bus */
static int of_mdio_bus_match(struct device *dev, void *mdio_bus_np)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at