Re: [PATCH V1 2/2] i2c: tegra: notify transfer-complete afterclearing status.

From: Wolfram Sang
Date: Sat May 12 2012 - 09:08:11 EST

On Mon, May 07, 2012 at 12:16:19PM +0530, Laxman Dewangan wrote:
> The notification of the transfer complete by calling complete()
> should be done after clearing all interrupt status.
> This may avoid the race condition of misconfigure the i2c controller
> in multi-core environment.

"may avoid" or "does avoid"? I.e. does it fix any bug that really
occured? Then I'd add a stable tag.

So far, applied to next.

> if (status & I2C_INT_PACKET_XFER_COMPLETE) {
> BUG_ON(i2c_dev->msg_buf_remaining);
> complete(&i2c_dev->msg_complete);
> }

Side note: If you see a way to handle the BUG invocations more
gracefully, that would be appreciated.



Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | |

Attachment: signature.asc
Description: Digital signature