Re: [PATCH] staging: comedi: Add helper macro for comedi pci driverboilerplate

From: Ian Abbott
Date: Sat May 12 2012 - 13:22:37 EST


On 11/05/2012 22:59, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
On Fri, May 11, 2012 at 01:26:37PM -0500, H Hartley Sweeten wrote:
How about doing this in the register function:

If (!pci_driver->name)
pci_driver->name = comedi_driver->driver_name;

This way all the drivers that still need to be refactored will still work.

After all the drivers have been updated, those two lines can be
removed.

So we have this patch and one big patch updating all the refactored
drivers. Some number of patches refactoring the remaining drivers
and using the module_comedi_pci_driver macro. Then one last
patch removing the check above.

How does that sound?

That sounds reasonable to me.

Sounds reasonable to me too.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/