Re: [PATCH 3/7] mmc: dw_mmc: add device tree support
From: Guennadi Liakhovetski
Date: Sat May 12 2012 - 15:31:50 EST
On Sat, 12 May 2012, Thomas Abraham wrote:
> On 4 May 2012 04:18, Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
> > What do you think about this patch
> > http://www.spinics.net/lists/linux-sh/msg11259.html
> > and about using mmc-generic OF properties instead of creating yet another
> > copy of proprietary ones?
> Hi Guennadi,
> This patch does not intend to add any custom mmc properties. I checked
> your patch (in the link mentioned above) and most of the bindings are
> similar to what you have come up with except for the "ro-gpios" for
> which I have used "wp-gpios". But this is following what Arnd had
> proposed here: http://www.spinics.net/lists/linux-mmc/msg13564.html.
Thanks for the link! I didn't know about that patch.
> Regarding the MMC_CAP_4_BIT_DATA and MMC_CAP_8_BIT_DATA in your patch,
> these can be derived from the bus width information that the driver
Sure. I think, my patch, that I mentioned above, shall be dropped, at
least in its present form. But if at least in principle we do want to have
a common MMC OF parser for common bindings, some code from your patch
would become redundant, I think. BTW, isn't this
+ gpio = of_get_named_gpio(np, "wp_gpios", 0);
a typo? Shouldn't it be "wp-gpios" instead?
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/