Re: [GIT PULL 0/8] Annotation weekly ponies delivery
From: Linus Torvalds
Date: Sat May 12 2012 - 16:40:29 EST
On Sat, May 12, 2012 at 12:52 PM, Arnaldo Carvalho de Melo
> Arjan & Linus Annotation Edition
I pulled this into my current git tree just for testing.
It's horribly broken, but it's not the annotation that is broken.
The whole "-e cycles:pp" doesn't work any more. I don't get any nice
PEBS information, I get the totally useless irq-based profiling.
The difference for a "make -j" profile is quite stunning:
Doing "perf record -f -e cycles:pp -F 20000 make -j"
- my current git:
[ perf record: Woken up 47 times to write data ]
[ perf record: Captured and wrote 11.890 MB perf.data (~519462 samples) ]
- with the above tree pulled into my current git tree (but compiling
the same old tree):
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.031 MB perf.data (~1375 samples) ]
and not suprisingly, the resulting profiles are crap due to lack of
reasonable sample coverage.
I don't think this has anything to do with your changes, but I thought
I'd report it anyway. Something in 'perf' land is broken.
> More like Linus', but hey at least an attempt at implementing a suggestion by
> Arjan made this time around!
> . Fix indirect calls beautifier, reported by Linus.
> . Use the objdump comments to nuke specificities about how access to a well
> know variable is encoded, suggested by Linus.
> . Show the number of places that jump to a target, requested by Arjan.
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Arnaldo Carvalho de Melo (8):
> perf annotate: Use raw form for register indirect call instructions
> perf annotate: Resolve symbols using objdump comment
> perf annotate: Resolve symbols using objdump comment for single op ins
> perf annotate: Augment lock instruction output
> perf annotate: Introduce ->free() method in ins_ops
> perf annotate browser: Count the numbers of jump sources to a target
> perf annotate browser: Show 'jumpy' functions
> perf annotate browser: Add key bindings help window
> tools/perf/ui/browsers/annotate.c | 94 ++++++++++--
> tools/perf/util/annotate.c | 303 +++++++++++++++++++++++++++++++++----
> tools/perf/util/annotate.h | 15 +-
> 3 files changed, 369 insertions(+), 43 deletions(-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/