Re: [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get_entry.
From: Namjae Jeon
Date: Sun May 13 2012 - 19:03:14 EST
2012/5/14, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
> Joe Perches <joe@xxxxxxxxxxx> writes:
>>> > Please don't split format strings.
>>> > It's much harder to grep.
>>> Please fight with 80 columns guys before requesting it.
>> That battle is long over.
>> from Documentation/CodingStyle:
>> Chapter 2: Breaking long lines and strings
>> The limit on the length of lines is 80 columns and this is a strongly
>> preferred limit.
>> However, never break user-visible strings such as
>> printk messages, because that breaks the ability to grep for them.
> Oh, I see. Namjae, can you adjust the patches to adjust for this?
> I don't care either one, so you can add the following if you tweaked
Okay, I will send you v2 patches for this.
Thanks for your help.
> Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/