Re: linux-next: build failure in Linus' tree

From: Grant Likely
Date: Mon May 14 2012 - 02:57:49 EST


On Mon, 14 May 2012 10:50:25 +1000, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> Hi Linus,
>
> Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> ERROR: "handle_edge_irq" [drivers/gpio/gpio-pch.ko] undefined!
> ERROR: "irq_to_desc" [drivers/gpio/gpio-pch.ko] undefined!
>
> This has been reported elsewhere by DaveM.
>
> Caused by commit df9541a60af0 ("gpio: pch9: Use proper flow type handlers").
>
> I have reverted that commit for today.

Gah, I tested that patch with CONFIG_GPIO_PCH=Y, but not as a module.
I see three options here; revert the patch now and fix it up in v3.4,
add exports for those two symbols, or disable building that code as a
module (patch below). Personally I prefer the third option for the
immediate fix.

g.