Re: [PATCH] update i_blocks on UFS
From: Evgeniy Dushistov
Date: Mon May 14 2012 - 07:56:55 EST
On Mon, May 14, 2012 at 12:16:27AM +0200, Vladimir 'Ï-coder/phcoder' Serbinenko wrote:
> On 13.05.2012 23:59, Evgeniy Dushistov wrote:
> > On Sun, May 13, 2012 at 03:52:46PM +0200, Vladimir 'Ï-coder/phcoder' Serbinenko wrote:
> >> UFS code dosn't update i_blocks which leads to the problems ranging from wrong
> >> stat/du to long symlinks (as opposed to inline ones) being damaged. This is
> >> a fix.
> > Yes, when quota support was removed, code that update statistic
> > about usage of blocks also was removed. But why so big change to fix this?
> > I found this problem some time ago and fixed it with code bellow,
> > but may be I missed something?
> Hm, I don't know why this code wasn't in my copy. Was it already
> propagated to Linus' tree? When will it be? Which tree I should merge
> from to get your latest fixes?
I created this patch some time ago, but forgot to merge it to main tree.
You email remind me about this problem.
> My code avoided counting metadata blocks (the ones holding the pointers
> to actual blocks in indirect, double-indirect and triple-indirect
> chains). I thought that i_blocks doesn't take into account the
> metablocks but quick experiment with NetBSD image proved me wrong. So I
> retract this patch altogether.
> My UFS file size limit patch remains though.
ok, so I will test your patch and my and then take care about merging
them into mainline.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/