Re: [PATCH] mmc:sdio:retry CMD52/53 when error happens
From: S, Venkatraman
Date: Mon May 14 2012 - 08:04:37 EST
On Mon, May 14, 2012 at 2:09 PM, yongd <yongd@xxxxxxxxxxx> wrote:
> Set sdio CMD52/53's retry time as MMC_CMD_RETRIES. As a result,
> sdio might benefit from core-internal CMD retry mechanism when
> some errors happen(CRC, etc).
>
> Signed-off-by: yongd <yongd@xxxxxxxxxxx>
> ---
> drivers/mmc/core/sdio_ops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/sdio_ops.c b/drivers/mmc/core/sdio_ops.c
> index d29e206..884c27e 100644
> --- a/drivers/mmc/core/sdio_ops.c
> +++ b/drivers/mmc/core/sdio_ops.c
> @@ -86,7 +86,7 @@ static int mmc_io_rw_direct_host(struct mmc_host *host, int write, unsigned fn,
> cmd.arg |= in;
> cmd.flags = MMC_RSP_SPI_R5 | MMC_RSP_R5 | MMC_CMD_AC;
>
> - err = mmc_wait_for_cmd(host, &cmd, 0);
> + err = mmc_wait_for_cmd(host, &cmd, MMC_CMD_RETRIES);
> if (err)
> return err;
>
> @@ -147,6 +147,7 @@ int mmc_io_rw_extended(struct mmc_card *card, int write, unsigned fn,
> else
> cmd.arg |= 0x08000000 | blocks; /* block mode */
> cmd.flags = MMC_RSP_SPI_R5 | MMC_RSP_R5 | MMC_CMD_ADTC;
> + cmd.retries = MMC_CMD_RETRIES;
>
> data.blksz = blksz;
> /* Code in host drivers/fwk assumes that "blocks" always is >=1 */
> --
Looks right to me.
Reviewed-by: Venkatraman S <svenkatr@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/