Re: [PATCH] Fix minixfs size check

From: Vladimir 'Ï-coder/phcoder' Serbinenko
Date: Mon May 14 2012 - 18:34:06 EST

On 15.05.2012 00:19, Jan Kara wrote:

> On Sun 13-05-12 15:48:55, Vladimir 'Ï-coder/phcoder' Serbinenko wrote:
>> minixfs file size check is buggy and it doesn't allow creating a block which
>> can't be fully filled
> Umm, I'm not really minix expert but who'd set s_max_size to something
> which is not a multiple of block size? This looks rather artifical problem
> to me...

The usual and natural limit comes from interpreting 32-bit size field as
signed or unsigned. So it's either 2G - 1 or 4G - 1. Neither of which is
a multiple of block size.
Vladimir 'Ï-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature