Re: [PATCH 2/3] zram: remove comment in Kconfig
From: Minchan Kim
Date: Mon May 14 2012 - 22:30:52 EST
On 05/14/2012 11:42 PM, Seth Jennings wrote:
> On 05/14/2012 03:45 AM, Minchan Kim wrote:
>> Exactly speaking, zram should has dependency with
>> zsmalloc, not x86. So x86 dependeny check is redundant.
>> Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx>
>> drivers/staging/zram/Kconfig | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>> diff --git a/drivers/staging/zram/Kconfig b/drivers/staging/zram/Kconfig
>> index 9d11a4c..ee23a86 100644
>> --- a/drivers/staging/zram/Kconfig
>> +++ b/drivers/staging/zram/Kconfig
>> @@ -1,8 +1,6 @@
>> config ZRAM
>> tristate "Compressed RAM block device support"
>> - # X86 dependency is because zsmalloc uses non-portable pte/tlb
>> - # functions
>> - depends on BLOCK && SYSFS && X86
>> + depends on BLOCK && SYSFS
> Two comments here:
> 1) zram should really depend on ZSMALLOC instead of selecting it
> because, as the patch has it, zram could be selected on an arch that
> zsmalloc doesn't support.
Argh, Totally my mistake. my patch didn't match with my comment, either. :(
> 2) This change would need to be done in zcache as well.
== CUT_HERE ==