Re: [PATCH v2] UBI: add lnum to struct ubi_work
From: Artem Bityutskiy
Date: Tue May 15 2012 - 07:23:11 EST
On Tue, 2012-05-15 at 14:14 +0300, Artem Bityutskiy wrote:
> On Mon, 2012-05-14 at 20:47 +0200, Joel Reardon wrote:
> > @@ -1086,13 +1090,14 @@ out_ro:
> > * @ubi: UBI device description object
> > * @pnum: physical eraseblock to return
> > * @torture: if this physical eraseblock has to be tortured
> > + * @lnum: the last used logical eraseblock number for the PEB
> > *
> > * This function is called to return physical eraseblock @pnum to the pool of
> > * free physical eraseblocks. The @torture flag has to be set if an I/O error
> > * occurred to this @pnum and it has to be tested. This function returns zero
> > * in case of success, and a negative error code in case of failure.
> > */
> > -int ubi_wl_put_peb(struct ubi_device *ubi, int pnum, int torture)
> > +int ubi_wl_put_peb(struct ubi_device *ubi, int pnum, int torture, int lnum)
> Joel, am sorry for nitpicking again, but could you please put the "lnum"
> argument between "ubi" and "lnum" instead? Just feels more natural.
> Otherwise the patch is OK. Thanks!
Err, but you also need volume ID, because there may be several volumes
with the same lnum.
Description: This is a digitally signed message part