Re: [PATCH v3 4/5] cpusets: Add provisions for distinguishing CPUHotplug in suspend/resume path
From: Srivatsa S. Bhat
Date: Tue May 15 2012 - 08:30:22 EST
On 05/15/2012 06:03 AM, David Rientjes wrote:
> On Mon, 14 May 2012, Srivatsa S. Bhat wrote:
>> Cpusets needs to distinguish between a regular CPU Hotplug operation and a
>> CPU Hotplug operation carried out as part of the suspend/resume sequence.
>> So add provisions to facilitate that, so that the two operations can be
>> handled differently.
> There's no functional change with this patch and it's unclear from this
> changelog why we need to distinguish between the two, so perhaps fold this
> into patch 5 or explain how this will be helpful in this changelog?
> Otherwise it doesn't seem justifiable to add 30 more lines of code.
Well, as 0/5 explains, this whole patchset is a suspend/resume-only fix.
So we need special-case handling for suspend/resume in cpusets. So the
additional code is justified, IMHO. It prepares the ground for patch 5.
Again, I split it up here because I didn't want to clutter patch 5; it is
complex enough as it is... ;-)
Srivatsa S. Bhat
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/