Re: [PATCH] clk: Constify struct clk_init_data

From: Saravana Kannan
Date: Tue May 15 2012 - 12:42:33 EST

On 05/15/2012 12:00 AM, Sascha Hauer wrote:
On Mon, May 14, 2012 at 06:19:16PM -0700, Saravana Kannan wrote:
On 05/14/2012 02:53 PM, Turquette, Mike wrote:
On Mon, May 14, 2012 at 7:12 AM, Mark Brown<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
Allow drivers to declare their clk_init_data const, the framework really
shouldn't be modifying the data.

Signed-off-by: Mark Brown<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

+interested parties

diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index c1c23b9..fc43ea6 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -143,7 +143,7 @@ struct clk_init_data {
struct clk_hw {
struct clk *clk;
- struct clk_init_data *init;
+ const struct clk_init_data *init;

Oh, wait. This won't work for the case where the clock registration
is completely dynamic. Say, created from device tree or thru some
PCI/USB device probe, etc. That's why I didn't add it before.

Why not? In this case clk_init_data is also only used in clk_register.
Given that Mark has posted the patch I assume it actually works.


It's used in __clk_register() though. Which I added as a "as close as clk_register() but allows static init" function.


Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at